Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit using features in the same file they're defined in. #16864

Merged
1 commit merged into from
May 16, 2024
Merged

Conversation

copybara-service[bot]
Copy link

Prohibit using features in the same file they're defined in.

This is an edge case we can't handle properly today. Rather than allowing poorly defined behavior, we'll make this an error condition until we can actually support it. In the future, it may be necessary to upgrade feature files to newer editions.

Closes #16756

@copybara-service copybara-service bot force-pushed the test_634122584 branch 2 times, most recently from 007ff07 to 68355fd Compare May 16, 2024 20:00
This is an edge case we can't handle properly today.  Rather than allowing poorly defined behavior, we'll make this an error condition until we can actually support it.  In the future, it may be necessary to upgrade feature files to newer editions.

Closes #16756

PiperOrigin-RevId: 634512378
@copybara-service copybara-service bot closed this pull request by merging all changes into main in 24b91a7 May 16, 2024
@copybara-service copybara-service bot deleted the test_634122584 branch May 16, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editions: options interpretation can generate incorrect results
2 participants