Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit using features in the same file they're defined in. #16875

Merged
merged 1 commit into from
May 16, 2024

Conversation

mkruskal-google
Copy link
Member

This is an edge case we can't handle properly today. Rather than allowing poorly defined behavior, we'll make this an error condition until we can actually support it. In the future, it may be necessary to upgrade feature files to newer editions.

Closes #16756

PiperOrigin-RevId: 634122584

This is an edge case we can't handle properly today.  Rather than allowing poorly defined behavior, we'll make this an error condition until we can actually support it.  In the future, it may be necessary to upgrade feature files to newer editions.

Closes #16756

PiperOrigin-RevId: 634122584
@mkruskal-google mkruskal-google added the back-port Cherrypick PRs to release branches label May 16, 2024
@mkruskal-google mkruskal-google requested a review from a team as a code owner May 16, 2024 20:00
@mkruskal-google mkruskal-google requested review from sbenzaquen and removed request for a team May 16, 2024 20:00
@mkruskal-google mkruskal-google merged commit 0a05aa8 into 27.x May 16, 2024
188 checks passed
@mkruskal-google mkruskal-google deleted the ban-recursive-features branch May 16, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-port Cherrypick PRs to release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants