Removed specific MSVC settings when installing #17285
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing protobuf, it creates a different directory for CMake's config files when compiling with MSVC.
gRPC build on Windows
![protobuf-on-windows](https://private-user-images.githubusercontent.com/50274155/344388675-b0f5e1fa-dcb8-4c01-8118-7c6c651cda37.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4NTMzOTIsIm5iZiI6MTcyMzg1MzA5MiwicGF0aCI6Ii81MDI3NDE1NS8zNDQzODg2NzUtYjBmNWUxZmEtZGNiOC00YzAxLTgxMTgtN2M2YzY1MWNkYTM3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE3VDAwMDQ1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM0ZmM3MTkwYzA5YmIxZTgyMDUyMWY2ODBjNWEyZDAxOGMxY2I2YzgxMWI2NDcxZTYwYjYxODMxZjA5NzA1NGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2aLHxpDiQkithMk8mffywqlL0dSVlmF46kSz0Q4OBzk)
gRPC build on Linux and macOS
![protobuf-on-linux](https://private-user-images.githubusercontent.com/50274155/344390189-1370b476-89e7-42a0-857d-73cdcbae4f23.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4NTMzOTIsIm5iZiI6MTcyMzg1MzA5MiwicGF0aCI6Ii81MDI3NDE1NS8zNDQzOTAxODktMTM3MGI0NzYtODllNy00MmEwLTg1N2QtNzNjZGNiYWU0ZjIzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE3VDAwMDQ1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMyY2FlODRiMDE0MzA4OWVhNjQ1YzhjOWFmZmZjZmZjMWZjMmEzZTA0ZDFmMzA0NjgxMmMxZjk5MWM0MDhiNmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.T9vn9zQQcgh1gxR_0Wj4JPsGHbl8OnF8CBr3SjJJ65Y)
This is problematic because it requires conditionally setting its
protobuf_DIR
for different platforms:The original commit that made this based its choice on CMake's version 3.4, which not only is deprecated but is also based on a CMake version less than the one defined in the master file. Since then, CMake changed its behaviour, making this distinction unnecessary.