Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arm/gcc] Don't rely on KUSER_HELPERS feature for atomics #2301

Merged

Conversation

jbrianceau
Copy link
Contributor

ARM specific CONFIG_KUSER_HELPERS feature can be disabled in Linux kernel,
and in this case, we shouldn't crash. Use gcc built-in functions instead
of arm specific code if they are available.

ARM specific CONFIG_KUSER_HELPERS feature can be disabled in Linux kernel,
and in this case, we shouldn't crash. Use gcc built-in functions instead
of arm specific code if they are available.
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 28, 2016

Thanks for the patch! Have you tested the change with both gcc compilers >= 4.7 and <4.7?

@xfxyjwf xfxyjwf self-assigned this Oct 28, 2016
@jbrianceau
Copy link
Contributor Author

We have tested the change with gcc compiler >= 4.7 and it works fine, i.e. when KUSER_HELPERS kernel feature is disabled, we do not crash anymore.
The change fallbacks with the current implementation so we didn't check with gcc compiler < 4.7

@jbrianceau
Copy link
Contributor Author

Do you need further information about this pull request @xfxyjwf ?

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Nov 3, 2016

No, this PR seems good to me. Merging now.

@xfxyjwf xfxyjwf merged commit 7bd11fc into protocolbuffers:master Nov 3, 2016
@jbrianceau jbrianceau deleted the arm-atomic-kuser-helpers-fix-v2 branch December 21, 2016 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants