Detect generated code of WKT, addressbook and conformance protos

[anandolee]

Add auto detect for generated code of WKT protos, addressbook.proto and conformance.proto

fixes #1212

[bazel-io]

Can one of the admins verify this patch?

[jskeet]

How hard would it be to read these parameters from a file instead? That way we could generate that file when we generate the protos with generate_all.sh or whatever it's called.

Just a thought for future expansion, really - it would be very easy to add a proto to be generated but forget to add it here.

[anandolee]

I'd prefer only add .proto files that are stable into the detect test. We'd better not add unittest .proto files into it which may both other languages too much. Keep these parameters in hard code makes the adding more serious and formal.

[jskeet]

So long as people know to make the change, of course. I agree it should be relatively rare. Do we have a document somewhere saying "When you add a WKT or similar, you should change X files; when you modify an existing WKT you should rerun Y generation." ?

[anandolee]

It is mentioned in the comments of this file:

// If this test fails, run the script
// "generate_descriptor_proto.sh" and add the changed files under
// csharp/src/ to your changelist.

And the error message will show which file should be regenerated and add to change list too:

EXPECT_TRUE(actual_contents == *expected_contents)
 << physical_filename << " needs to be regenerated. Please run "
 "generate_descriptor_proto.sh. Then add this file "

Is it enough?

[jskeet]

That's okay for knowing what to do if the test fails - it's more when the tests should be expanded. But that can definitely come later.