Add new file option php_namespace. #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this option to change the namespace of php generated classes. Default is empty. When this option is empty, the package name will be used for determining the namespace.
|
Can one of the admins verify this patch? |
php/tests/array_test.php
Outdated
| $end = memory_get_usage(); | ||
| $this->assertLessThan($start, $end); | ||
| } | ||
| # /** |
There was a problem hiding this comment.
Are these tests supposed to be commented out?
|
Thanks for the catch. |
|
Testing locally, I am finding that this does not change the namespace of the GPBMetadata files. Is that intentional? I do not know of strong arguments either for changing it or not. |
|
I don't think we need to change the namespace of GPBMetadata files. These files are transparent to users. |
|
BTW, the namespace of GPBMetadata files are decided by the path of proto file instead of the package name. |
TeBoring
added a commit
to TeBoring/protobuf
that referenced
this pull request
Jun 20, 2017
* Add new file option php_namespace. Use this option to change the namespace of php generated classes. Default is empty. When this option is empty, the package name will be used for determining the namespace. * Uncomment commented tests * Revert gdb test change * Update csharp descriptor. * Add test for empty php_namespace.
5 tasks
3 tasks
|
@TeBoring What time php_namespace. protoc 3.4? |
|
ETA end of July. |
This was referenced Apr 11, 2023
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
* Add new file option php_namespace. Use this option to change the namespace of php generated classes. Default is empty. When this option is empty, the package name will be used for determining the namespace. * Uncomment commented tests * Revert gdb test change * Update csharp descriptor. * Add test for empty php_namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this option to change the namespace of php generated classes.
Default is empty. When this option is empty, the package name will be
used for determining the namespace.