Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS2017 optional component dependency details to the C# ReadMe for #4119 #4128

Merged
merged 1 commit into from
May 3, 2018
Merged

Add VS2017 optional component dependency details to the C# ReadMe for #4119 #4128

merged 1 commit into from
May 3, 2018

Conversation

dchennells
Copy link
Contributor

Add mention to the "Build" section of the ReadMe of the requirement of installing an optional component to VS2017, as discussed with @jskeet in #4119.

Add mention to the "Build" section of the ReadMe of the requirement of installing an optional component to VS2017.
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@jskeet
Copy link
Contributor

jskeet commented Jan 3, 2018

I'm fine with this - assigned @anandolee as protobuf team member.

@dchennells
Copy link
Contributor Author

I signed the Contributor License Agreement (CLA).

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 3, 2018
@anandolee anandolee merged commit 513b35d into protocolbuffers:master May 3, 2018
@xfxyjwf xfxyjwf added the c# label Jun 22, 2018
hpohl pushed a commit to pley-games/protobuf that referenced this pull request Aug 14, 2018
…otocolbuffers#4128)

Add mention to the "Build" section of the ReadMe of the requirement of installing an optional component to VS2017.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants