Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guards for older GCC versions #4159

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/google/protobuf/any.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/api.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/compiler/cpp/cpp_file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1363,7 +1363,7 @@ void FileGenerator::GenerateInlineFunctionDefinitions(io::Printer* printer) {
// TODO(gerbens) remove pragmas when gcc is no longer used. Current version
// of gcc fires a bogus error when compiled with strict-aliasing.
printer->Print(
"#ifdef __GNUC__\n"
"#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)\n"
" #pragma GCC diagnostic push\n"
" #pragma GCC diagnostic ignored \"-Wstrict-aliasing\"\n"
"#endif // __GNUC__\n");
Expand All @@ -1376,7 +1376,7 @@ void FileGenerator::GenerateInlineFunctionDefinitions(io::Printer* printer) {
message_generators_[i]->GenerateInlineMethods(printer);
}
printer->Print(
"#ifdef __GNUC__\n"
"#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)\n"
" #pragma GCC diagnostic pop\n"
"#endif // __GNUC__\n");

Expand Down
4 changes: 2 additions & 2 deletions src/google/protobuf/compiler/plugin.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/descriptor.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/duration.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/empty.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/field_mask.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/source_context.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/struct.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/timestamp.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/type.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/google/protobuf/wrappers.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion third_party/benchmark
Submodule benchmark updated 78 files
+0 −5 .clang-format
+0 −28 .travis-libcxx-setup.sh
+26 −0 .travis-setup.sh
+24 −138 .travis.yml
+0 −9 AUTHORS
+6 −62 CMakeLists.txt
+0 −10 CONTRIBUTORS
+28 −393 README.md
+110 −39 appveyor.yml
+4 −31 cmake/AddCXXCompilerFlag.cmake
+3 −10 cmake/CXXFeatureCheck.cmake
+0 −1 cmake/Config.cmake.in
+0 −59 docs/tools.md
+4 −1,193 include/benchmark/benchmark.h
+633 −19 include/benchmark/benchmark_api.h
+48 −0 include/benchmark/macros.h
+110 −9 include/benchmark/reporter.h
+24 −51 src/CMakeLists.txt
+4 −3 src/arraysize.h
+718 −441 src/benchmark.cc
+0 −46 src/benchmark_api_internal.h
+0 −467 src/benchmark_register.cc
+21 −40 src/check.h
+15 −87 src/colorprint.cc
+1 −15 src/colorprint.h
+17 −15 src/commandlineflags.cc
+2 −5 src/commandlineflags.h
+0 −324 src/complexity.cc
+0 −60 src/complexity.h
+62 −106 src/console_reporter.cc
+0 −68 src/counter.cc
+54 −93 src/csv_reporter.cc
+6 −33 src/cycleclock.h
+19 −36 src/internal_macros.h
+63 −65 src/json_reporter.cc
+40 −0 src/log.cc
+11 −56 src/log.h
+57 −70 src/mutex.h
+3 −83 src/re.h
+59 −0 src/re_posix.cc
+26 −8 src/re_std.cc
+63 −33 src/reporter.cc
+1 −2 src/sleep.cc
+7 −5 src/sleep.h
+8 −11 src/stat.h
+22 −25 src/string_util.cc
+13 −9 src/string_util.h
+129 −64 src/sysinfo.cc
+2 −0 src/sysinfo.h
+0 −212 src/timers.cc
+0 −48 src/timers.h
+263 −0 src/walltime.cc
+17 −0 src/walltime.h
+8 −86 test/CMakeLists.txt
+22 −19 test/basic_test.cc
+41 −75 test/benchmark_test.cc
+0 −167 test/complexity_test.cc
+7 −24 test/cxx03_test.cc
+0 −64 test/diagnostics_test.cc
+0 −52 test/donotoptimize_test.cc
+21 −34 test/filter_test.cc
+6 −3 test/fixture_test.cc
+7 −5 test/map_test.cc
+0 −74 test/multiple_ranges_test.cc
+7 −30 test/options_test.cc
+0 −201 test/output_test.h
+0 −423 test/output_test_helper.cc
+0 −182 test/register_benchmark_test.cc
+0 −256 test/reporter_output_test.cc
+0 −150 test/skip_with_error_test.cc
+0 −250 test/user_counters_tabular_test.cc
+0 −217 test/user_counters_test.cc
+0 −68 tools/compare_bench.py
+0 −60 tools/gbench/Inputs/test1_run1.json
+0 −60 tools/gbench/Inputs/test1_run2.json
+0 −8 tools/gbench/__init__.py
+0 −146 tools/gbench/report.py
+0 −159 tools/gbench/util.py