Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the use of Unsafe conditional #4557

Closed
wants to merge 1 commit into from

Conversation

eed3si9n
Copy link

Ref #3781

This is an attempt to workaround the Unsafe warning on JDK 9+.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@eed3si9n
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Apr 26, 2018

@eed3si9n Thanks for the patch, but I don't think we can just disable unsafe like this as we have code paths relying on the use of unsafe. I'm working on integrating our internal Java changes to github right now and we should fix the Java 9 issue after all the changes are integrated.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented May 14, 2018

I'm closing this PR for now.

@xfxyjwf xfxyjwf closed this May 14, 2018
@eed3si9n
Copy link
Author

@xfxyjwf Could you update the status on #3781 please?
What's the expected schedule for the integration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants