-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the use of Unsafe conditional #4557
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
@eed3si9n Thanks for the patch, but I don't think we can just disable unsafe like this as we have code paths relying on the use of unsafe. I'm working on integrating our internal Java changes to github right now and we should fix the Java 9 issue after all the changes are integrated. |
I'm closing this PR for now. |
Ref #3781
This is an attempt to workaround the Unsafe warning on JDK 9+.