Update code to work for Xcode 10b1 #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
reviewed
Jun 5, 2018
| @@ -2537,12 +2537,12 @@ - (NSUInteger)countByEnumeratingWithState:(NSFastEnumerationState *)state | |||
| return [_array countByEnumeratingWithState:state objects:buffer count:len]; | |||
| } | |||
|
|
|||
| - (void)enumerateObjectsUsingBlock:(void (^)(id obj, NSUInteger idx, BOOL *stop))block { | |||
| - (void)enumerateObjectsUsingBlock:(void (NS_NOESCAPE ^)(id obj, NSUInteger idx, BOOL *stop))block { | |||
There was a problem hiding this comment.
Please update objectivec/README.md, i believe it says we just require Xcode 7.0, so this likely needs to be raised.
There was a problem hiding this comment.
Done, also updated the script
There was a problem hiding this comment.
Actually, don't we also want the NO_ESCAPE in the header also so code calling this is correct?
There was a problem hiding this comment.
And no we don't since these are just the hooked cases. We probably should add NOESCAPE to the GPB ones, but that can happen later.
thomasvl
approved these changes
Jun 5, 2018
acozzette
pushed a commit
to acozzette/protobuf
that referenced
this pull request
Jun 5, 2018
* Update code to work for Xcode 10b * Update README and test scripts to mention that Xcode 7 is no longer supported
shirl-resonai
pushed a commit
to resonai/protobuf
that referenced
this pull request
Oct 14, 2018
* Update code to work for Xcode 10b * Update README and test scripts to mention that Xcode 7 is no longer supported
shirl-resonai
added a commit
to resonai/protobuf
that referenced
this pull request
Oct 15, 2018
…code 10b1 (protocolbuffers#4729) Update code to work for Xcode 10b1 (protocolbuffers#4729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.