[WIP] Improve C# serialization performance - ArrayValueWriter #5828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes issue #5822
This applies the same style optimizations that are done in WriteString, handling the "common case".
I need to sort out indentation to match the project. I'm opening this up for initial feedback. I've moved incrementing the position member variable to outside of the loops as I saw it generated less assembly and appeared to perform better on Release builds for my profiling.
I'm seeing about 100% speed improvements for repeated fields on primitives, so I'd be curious if others see the same too. These optimizations are applied only if the entire array fits within the buffer, otherwise performance should be the same. This optimization should be covered by the existing unit tests which test varying buffer sizes, but the test data could be added to providing longer repeated fields.