Replace strptime with custom implementation #5906

TeBoring · 2019-03-17T05:31:04Z

ruby/ext/google/protobuf_c/upb.c

knu · 2019-04-10T06:07:30Z

ruby/ext/google/protobuf_c/upb.c

@@ -14311,7 +14311,7 @@ static bool end_timestamp_zone(upb_json_parser *p, const char *ptr) {
  }

  /* Normalize tm */
-  seconds = timegm(&p->tm);
+  seconds = mktime(&p->tm) - timezone;


This does not work on *BSD platforms where timezone is not a long int variable but a function.

Is this change due to timegm() not available everywhere?

TeBoring added 2 commits March 17, 2019 05:24

Replace strptime with custom implementation

a818610

Fix ruby strptime

7f37f25

googlebot added the cla: yes label Mar 17, 2019

TeBoring changed the title ~~Ruby fix~~ Replace strptime with custom implementation Mar 17, 2019

TeBoring requested a review from haberman March 17, 2019 05:38

TeBoring assigned haberman Mar 17, 2019

TeBoring added the ruby label Mar 17, 2019

TeBoring and others added 4 commits March 17, 2019 05:48

Fix test

73ef535

Fix ruby conformance test

07197b9

Use mktime

f74f023

Remove EmptyFieldMask from failed conformance test list

9786ad5

haberman reviewed Mar 18, 2019

View reviewed changes

ruby/ext/google/protobuf_c/upb.c Show resolved Hide resolved

TeBoring merged commit 57b6597 into protocolbuffers:3.7.x Mar 20, 2019

TeBoring deleted the ruby-fix branch March 21, 2019 04:31

knu reviewed Apr 10, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace strptime with custom implementation #5906

Replace strptime with custom implementation #5906

TeBoring commented Mar 17, 2019 •

edited

Loading

knu Apr 10, 2019

Replace strptime with custom implementation #5906

Replace strptime with custom implementation #5906

Conversation

TeBoring commented Mar 17, 2019 • edited Loading

knu Apr 10, 2019

Choose a reason for hiding this comment

TeBoring commented Mar 17, 2019 •

edited

Loading