Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bytes field to be longer than 16000 bytes #5924

Merged
merged 2 commits into from Mar 25, 2019
Merged

Allow bytes field to be longer than 16000 bytes #5924

merged 2 commits into from Mar 25, 2019

Conversation

TeBoring
Copy link
Contributor

Fix #5911

@TeBoring TeBoring requested a review from haberman March 21, 2019 04:38
@TeBoring TeBoring added this to the v3.7.0 milestone Mar 21, 2019
@TeBoring TeBoring added the ruby label Mar 21, 2019
@fables-tales
Copy link
Contributor

This patch LGTM, but I see your ruby 2.3 build is failing on mac.

@TeBoring
Copy link
Contributor Author

ruby 2.3 has already failed for some time. It's due to some unrelated issue.

@TeBoring TeBoring merged commit ba42cb5 into protocolbuffers:3.7.x Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haberman haberman haberman approved these changes

Assignees

@haberman haberman

Labels
cla: yes ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TeBoring @fables-tales @haberman @googlebot