Update addressbook.proto and examples code to proto3 #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thanks, will wait for travis and then merge. |
Merged
jtattermusch
added a commit
that referenced
this pull request
Jul 21, 2015
Update addressbook.proto and examples code to proto3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to address issue #565 (which is blocking merging C# into master).
This also reveals that despite style guide says that repeated fields should use name in plural form, the generated code doesn't really reflect that (in sense providing sane names for the generated members). Correct naming of fields in addressbook.proto ("phones" and "persons") results in code that's a bit wierd (e.g. method addPersons adds a single person)
https://sites.google.com/a/google.com/protocol-buffers/user-docs/style-guide#Naming_convention_for_repeated_e
@jskeet FYI