Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document proto2 feature implementations in Google.Protobuf #6499

Merged
merged 4 commits into from Sep 3, 2019
Merged

Document proto2 feature implementations in Google.Protobuf #6499

merged 4 commits into from Sep 3, 2019

Conversation

ObsidianMinor
Copy link
Contributor

@jtattermusch jtattermusch self-assigned this Aug 25, 2019
@jtattermusch jtattermusch self-requested a review August 25, 2019 15:13
jtattermusch
jtattermusch reviewed Aug 29, 2019
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation! Overall it's looking pretty good, but adding a bunch of suggestions for improvements anyway.

docs/csharp/proto2.md Outdated Show resolved Hide resolved
docs/csharp/proto2.md Outdated Show resolved Hide resolved
docs/csharp/proto2.md Outdated Show resolved Hide resolved
docs/csharp/proto2.md Outdated Show resolved Hide resolved
docs/csharp/proto2.md Outdated Show resolved Hide resolved
docs/csharp/proto2.md Show resolved Hide resolved
docs/csharp/proto2.md Outdated Show resolved Hide resolved
docs/csharp/proto2.md Outdated Show resolved Hide resolved
docs/csharp/proto2.md Outdated Show resolved Hide resolved
docs/csharp/proto2.md Show resolved Hide resolved
@ObsidianMinor
Update proto2.md
7feb16a 
Addressed review comments
@ObsidianMinor
Update proto2.md
c9a9818 
Reworded info about message initialization
@ObsidianMinor
Copy link
Contributor Author

I've addressed your review comments @jtattermusch

jtattermusch
jtattermusch reviewed Sep 3, 2019
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing one last comment.
I think we will merge this together with #5936.

docs/csharp/proto2.md Outdated Show resolved Hide resolved
@jtattermusch jtattermusch merged commit 94cbf00 into protocolbuffers:master Sep 3, 2019
@jtattermusch jtattermusch mentioned this pull request Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch jtattermusch left review comments

@anandolee anandolee Awaiting requested review from anandolee

Assignees

@jtattermusch jtattermusch

@anandolee anandolee

Labels
c# cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ObsidianMinor @jtattermusch @googlebot @anandolee @protobuf-kokoro