Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Add Google::Protobuf::Timestamp.from_time #6685

Conversation

DerekStride
Copy link

Previously, you would have to instantiate a timestamp class then call #from_time on that object to mutate its state. Instead provides a mechanism to instantiate the object with the correct state.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Previously, you would have to instantiate a timestamp class
then call #from_time on that object to mutate it's state. Instead
this provides a mechanism to instantiate the object with the correct
state.
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jufemaiz
Copy link
Contributor

jufemaiz commented Feb 3, 2021

I can only assume that this was abandoned @DerekStride ?

@DerekStride
Copy link
Author

I closed it because of a lack of involvement from the maintainers but I still think this is a valuable change

@jufemaiz
Copy link
Contributor

jufemaiz commented Feb 5, 2021

Ok sweet. See #8254 (also expands to resolve similar issue with other well known types)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants