Fix CLI "too long" issues in py_proto_library. #7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envoy was experiencing failed builds due to lots of duplicate -I in the CLI. The solution is to generally use depset() as per Starlark best practice for this sort of thing. Might fix other issues beyond py_proto_library, anything that depends on proto_gen. release notes: no Signed-off-by: Harvey Tuch <htuch@google.com>
|
@htuch I see a Bazel error in the CI test, do you know what that is about? |
Signed-off-by: Harvey Tuch <htuch@google.com>
|
@acozzette should be fixed now, can you run CI again? Thanks. |
|
Thanks, @htuch. |
|
@htuch Suspecting this as the root-cause for the failure on Bazel-CI. https://buildkite.com/bazel/protobuf/builds/3316 |
htuch
added a commit
to htuch/protobuf
that referenced
this pull request
May 26, 2020
See protocolbuffers#7458 (comment). release notes: no Signed-off-by: Harvey Tuch <htuch@google.com>
acozzette
pushed a commit
that referenced
this pull request
May 29, 2020
See #7458 (comment). release notes: no Signed-off-by: Harvey Tuch <htuch@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy was experiencing failed builds due to lots of duplicate -I in the
CLI. The solution is to generally use depset() as per Starlark best
practice for this sort of thing.
Might fix other issues beyond py_proto_library, anything that depends on
proto_gen.
release notes: no
Signed-off-by: Harvey Tuch htuch@google.com