Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format default values for "present" fields regardless of value #7487

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Format default values for "present" fields regardless of value #7487

merged 2 commits into from
Jun 11, 2020

Commits on Jun 10, 2020

  1. Changes how JSON formatting works for fields supporting presence 

    Fixes protocolbuffers#7486.

Note that this changes the behavior for message fields where
"WithFormatDefaultValues(true)" has been specified. This is
effectively fixing a bug, but will need to be noted in the release
notes.

Basically, FormatDefaultValues only affects fields that don't
support presence - most commonly, singular primitive non-optional
fields in proto3.
    @jskeet
    jskeet committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    3e85179 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Add support for proto2 JSON parsing in C# conformance tests

    @jskeet
    jskeet committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    a2852d6 View commit details
    Browse the repository at this point in the history