Mark some Bazel targets as "manual." #7932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python C++ extension targets are not used unless `--@:use_fast_cpp_protos=true`, and may not even be able to build if the Python headers are missing (note that `//util/python:python_headers`, bound to `@python_headers//` in `//:WORKSPACE`, is not currently sufficient). This change adds the `"manual"` tag to these targets, so that they do not cause `bazel test ...` to fail when Python headers are missing. Without the manual tag, the targets are always selected, even if `--@:use_fast_cpp_protos=false`. The `:cc_proto_blacklist_test` target is metastable, depending on whether the `--proto_toolchain_for_cc=` flag names a target with or without the `@com_google_protobuf//` prefix. We use the correct prefix for Bazel's default in `kokoro/linux/bazel/build.sh`, but the `bazel test :cc_proto_blacklist_test` (with or without `//`) fails consistently. Hopefully, this will be fixed when bazelbuild/bazel#10590 is addressed.
acozzette
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python C++ extension targets are not used unless
--@:use_fast_cpp_protos=true, and may not even be able to buildif the Python headers are missing (note that
//util/python:python_headers, bound to@python_headers//in//:WORKSPACE, is not currently sufficient). This change adds the"manual"tag to these targets, so that they do not causebazel test ...to fail when Python headers are missing. Withoutthe manual tag, the targets are always selected, even if
--@:use_fast_cpp_protos=false.The
:cc_proto_blacklist_testtarget is metastable, depending onwhether the
--proto_toolchain_for_cc=flag names a target withor without the
@com_google_protobuf//prefix. We use the correctprefix for Bazel's default in
kokoro/linux/bazel/build.sh, butthe
bazel test :cc_proto_blacklist_test(with or without//)fails consistently. Hopefully, this will be fixed when
bazelbuild/bazel#10590 is addressed.