Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podspec by adding missing comma #796

Merged
merged 1 commit into from Sep 5, 2015

Conversation

jcanizales
Copy link
Contributor

@TeBoring to review.

@nicolasnoble: This is the change I told you that Beta gRPC needs.

TeBoring added a commit that referenced this pull request Sep 5, 2015
Fix podspec by adding missing comma
@TeBoring TeBoring merged commit e473761 into protocolbuffers:master Sep 5, 2015
@jcanizales
Copy link
Contributor Author

Bo, do you want me to send the change to a branch besides master?

@TeBoring
Copy link
Contributor

TeBoring commented Sep 5, 2015

Has this blocked the release of grpc?
On Fri, Sep 4, 2015 at 22:31 Jorge Canizales notifications@github.com
wrote:

Bo, do you want me to send the change to a branch besides master?


Reply to this email directly or view it on GitHub
#796 (comment).

@jcanizales
Copy link
Contributor Author

It breaks the compile of protobuf using the podspec (because it makes the Wrappers.pbobjc.h and .m files to be ignored). We need it for our beta (0.11) release.

@TeBoring
Copy link
Contributor

TeBoring commented Sep 5, 2015

Could you merge it to the beta-1 branch?
On Fri, Sep 4, 2015 at 22:36 Jorge Canizales notifications@github.com
wrote:

It breaks the compile of protobuf using the podspec (because it makes the
Wrappers.pbobjc.h and .m files to be ignored). We need it for our beta
(0.11) release.


Reply to this email directly or view it on GitHub
#796 (comment).

@jcanizales
Copy link
Contributor Author

Sure

TeBoring added a commit that referenced this pull request Sep 5, 2015
Fix podspec by adding missing comma
@TeBoring
Copy link
Contributor

TeBoring commented Sep 5, 2015

I created v3.0.0-alpha-4.1 branch with your change. Could you check it works?

abergmeier pushed a commit to abergmeier/protobuf that referenced this pull request May 15, 2019
)

It is spec'd that way, but best practice is to avoid it.
rinarakaki pushed a commit to rinarakaki/protobuf that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants