New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GOOGLE_ATTRIBUTE_NOINLINE to GetArena() and GetMaybeArenaPointer(… #813
Conversation
…) methods. This is to avoid "unresolved link" errors in MSVC 2015 during Release build
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! вт, 15 сент. 2015 г. в 1:48, googlebot notifications@github.com:
|
CLAs look good, thanks! |
Thanks! I'll merge this pull request after the tests complete. |
Strange fail: "Build execution time has reached the maximum allowed time for your plan (40 minutes)." |
I guess it's just the appveyor test being flaky. Merging. |
Add GOOGLE_ATTRIBUTE_NOINLINE to GetArena() and GetMaybeArenaPointer(…
* protocolbuffers/protobuf#240 * protocolbuffers/protobuf#813 * Add GOOGLE_ATTRIBUTE_NOINLINE to GetArena() and GetMaybeArenaPointer() methods. * This is to avoid "unresolved link" errors in MSVC 2015 during Release build
In protocolbuffers#726 and protocolbuffers#813, linking errors with MSVC14 were resolved. The change in MSVC12 leading to these errors was not a newly introduced bug, but that /Zc:inline was made on by default. This option is also available with MSVC12, so the workaround should be applied for it too.
…n-when-bunling-modules Use protobuf/minimal when pbjs target is static-module
"minimal" doesn't include `Root`, as mentioned in protocolbuffers#828 and protocolbuffers#856. Probably caused by protocolbuffers#813.
…) methods. This is to avoid "unresolved link" errors in MSVC 2015 during Release build