Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GOOGLE_ATTRIBUTE_NOINLINE to GetArena() and GetMaybeArenaPointer(… #813

Merged
merged 1 commit into from Sep 16, 2015

Conversation

0xAAE
Copy link
Contributor

@0xAAE 0xAAE commented Sep 14, 2015

…) methods. This is to avoid "unresolved link" errors in MSVC 2015 during Release build

…) methods. This is to avoid "unresolved link" errors in MSVC 2015 during Release build
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@0xAAE
Copy link
Contributor Author

0xAAE commented Sep 14, 2015

I signed it!

вт, 15 сент. 2015 г. в 1:48, googlebot notifications@github.com:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#813 (comment).

С уважением, Авраменко А.

@googlebot
Copy link

CLAs look good, thanks!

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Sep 14, 2015

Thanks! I'll merge this pull request after the tests complete.

@0xAAE
Copy link
Contributor Author

0xAAE commented Sep 16, 2015

Strange fail: "Build execution time has reached the maximum allowed time for your plan (40 minutes)."
What can I do!?

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Sep 16, 2015

I guess it's just the appveyor test being flaky. Merging.

xfxyjwf added a commit that referenced this pull request Sep 16, 2015
Add GOOGLE_ATTRIBUTE_NOINLINE to GetArena() and GetMaybeArenaPointer(…
@xfxyjwf xfxyjwf merged commit c941891 into protocolbuffers:master Sep 16, 2015
smanders pushed a commit to smanders/externpro that referenced this pull request Feb 9, 2016
* protocolbuffers/protobuf#240
* protocolbuffers/protobuf#813
* Add GOOGLE_ATTRIBUTE_NOINLINE to GetArena() and GetMaybeArenaPointer() methods.
* This is to avoid "unresolved link" errors in MSVC 2015 during Release build
MarcelRaad added a commit to MarcelRaad/protobuf that referenced this pull request Feb 17, 2017
In protocolbuffers#726 and protocolbuffers#813, linking errors with MSVC14 were resolved. The change in
MSVC12 leading to these errors was not a newly introduced bug, but that
/Zc:inline was made on by default. This option is also available with MSVC12,
so the workaround should be applied for it too.
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
…n-when-bunling-modules

Use protobuf/minimal when pbjs target is static-module
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
"minimal" doesn't include `Root`, as mentioned in protocolbuffers#828 and protocolbuffers#856. Probably caused by protocolbuffers#813.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants