Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing -llog when compiling for android #8285

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

s1341
Copy link
Contributor

@s1341 s1341 commented Feb 11, 2021

When cross-compiling for android, the android logging code is activated, but liblog.so is not linked in.

This patch fixes that.

@google-cla
Copy link

google-cla bot commented Feb 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 11, 2021
@s1341
Copy link
Contributor Author

s1341 commented Feb 11, 2021

@googlebot I signed it!

@s1341
Copy link
Contributor Author

s1341 commented Feb 14, 2021

What are the checks which failed? Clicking details gives me an 'oops' page.

@acozzette
Copy link
Member

I think the test failures are probably caused by an unrelated issue that we've since fixed, let me rerun them and see if they pass now.

@s1341
Copy link
Contributor Author

s1341 commented Mar 13, 2021

Awesome. This seems ready to merge!

@acozzette acozzette merged commit 28dbe3b into protocolbuffers:master Mar 15, 2021
@s1341
Copy link
Contributor Author

s1341 commented Mar 15, 2021

Thanks!

bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
Fix missing -llog when compiling for android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants