-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing -llog when compiling for android #8285
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
What are the checks which failed? Clicking details gives me an 'oops' page. |
I think the test failures are probably caused by an unrelated issue that we've since fixed, let me rerun them and see if they pass now. |
Awesome. This seems ready to merge! |
Thanks! |
Fix missing -llog when compiling for android
When cross-compiling for android, the android logging code is activated, but liblog.so is not linked in.
This patch fixes that.