Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js: use commonjs_strict for well-known types #8955

Closed
wants to merge 1 commit into from
Closed

js: use commonjs_strict for well-known types #8955

wants to merge 1 commit into from

Commits on Sep 6, 2021

  1. js: use commonjs_strict for well-known types 

    When generating JS code for .proto files which included well-known types
with the commonjs_strict import style, the generated code would import
generated JS code for the well-known types with the commonjs import
style (located in the google-protobuf NPM package). This causes several
issues as discussed in #7778.

This CL changes this so when using commonjs_strict, the imported
generated JS code for well-known types also uses commonjs_strict.

Fixes #7778
    @avm99963
    avm99963 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    a6ed2cf View commit details
    Browse the repository at this point in the history