Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Field Presence doc #8959

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Conversation

VeryStrongFingers
Copy link
Contributor

Updated information surrounding the usage of optional and the --experimental_allow_proto3_optional flag with relevant information between v3.12 & 3.15.

Since release v3.15:

Optional fields for proto3 are enabled by default, and no longer require
the --experimental_allow_proto3_optional flag.

Now the doc infers the feature is implicitly enabled, rather than an experimental flag which was only true up until v3.15.0

see notes on optional/--experimental_allow_proto3_optional here:

Updated information surrounding the usage of `optional` and the `--experimental_allow_proto3_optional` flag with relevant information between v3.12 & 3.15.

Since release v3.15:
>  Optional fields for proto3 are enabled by default, and no longer require
>  the --experimental_allow_proto3_optional flag.
@google-cla
Copy link

google-cla bot commented Sep 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 9, 2021
@VeryStrongFingers
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 9, 2021
@@ -198,10 +198,10 @@ If client A depends on _explicit presence_ for `foo`, then a "round trip" throug

## How to enable _explicit presence_ in proto3

These are the general steps to use the experimental field tracking support for proto3:
These are the general steps to u field tracking support for proto3:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "use"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed that up

@haberman haberman merged commit 757615a into protocolbuffers:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants