Standardize on Array copyOf #9162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
added a commit
to acozzette/protobuf
that referenced
this pull request
Jan 11, 2022
This reverts commit 935d099 from PR protocolbuffers#9162. While the original commit was a nice simplification, I learned from another Googler that there is unfortunately a performance cost to this (or at least there was last time this change was attempted). Even if it turns out to be fast on modern Java runtimes, we still care about the performance on old Android devices.
acozzette
added a commit
that referenced
this pull request
Jan 11, 2022
This reverts commit 935d099 from PR #9162. While the original commit was a nice simplification, I learned from another Googler that there is unfortunately a performance cost to this (or at least there was last time this change was attempted). Even if it turns out to be fast on modern Java runtimes, we still care about the performance on old Android devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code already uses instances of copyOf, make it the standard.
https://docs.oracle.com/javase/7/docs/api/java/util/Arrays.html