Fix benchmark by making sure we use Python 3 #9170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
force-pushed
the
fix-benchmark
branch
3 times, most recently
from
ae2aae5
to
a825d2f
Compare
acozzette
force-pushed
the
fix-benchmark
branch
4 times, most recently
from
65b565e
to
8a095b4
Compare
The benchmark runs have been failing since we started requiring Python 3, so this changes fixes the benchmarks by ensuring we always use Python 3.
acozzette
force-pushed
the
fix-benchmark
branch
from
8a095b4
to
d39edb8
Compare
|
I had to make a few more tweaks to get the benchmarks fully working again but now they finally run successfully. |
elharo
approved these changes
Oct 30, 2021
acozzette
added a commit
to acozzette/protobuf
that referenced
this pull request
Nov 1, 2021
The benchmark runs have been failing since we started requiring Python 3, so this changes fixes the benchmarks by ensuring we always use Python 3.
acozzette
added a commit
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark runs have been failing since we started requiring Python
3, so this changes fixes the benchmarks by ensuring we always use Python
3.