Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I found that if I include the auto generated XX.pb.h in my code then the "max" macro defined by Windows will be broken.
And this is caused by a direct undef in
src/google/protobuf/arena.h
I think this should be done by using
port_def.inc
andport_undef.inc
pairs so I removed this undef and add a protect onsrc/google/protobuf/stubs/stl_util.h
.Thank you