[Bazel] Move Python rules to //python #9952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dlj-NaN
commented
May 12, 2022
dlj-NaN
commented
- This PR moves Python rules to //python, but leaves aliases for publicly-visible targets.
- There is some internal cleanup for how we copy .proto sources so they are usable from Python.
- python/BUILD.bazel is now more in line with Bazel's BUILD style guide.
dlj-NaN
force-pushed
the
python-bazel
branch
2 times, most recently
from
c2f1c61
to
25df3da
Compare
haberman
approved these changes
May 12, 2022
| DefaultInfo(files = depset([dest for src, dest in src_dests])), | ||
| ] | ||
|
|
||
| internal_copy_files_impl = rule( |
There was a problem hiding this comment.
Could you add some more comments for the semantics of this rule and the attributes?
It's not immediately clear to me what this rule does at a high level, or why it needs to make a batch file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.