Use pkg_files for python source tarball. #1444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_553298266
branch
from
bf4ac46
to
78388ef
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_553298266
branch
6 times, most recently
from
85ee41d
to
70b3313
Compare
copybara-service
bot
force-pushed
the
test_553298266
branch
from
70b3313
to
3d0119a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pkg_files for python source tarball.
The file structure was broken only when invoking from protobuf repo (
bazel build @upb//python/dist:source_tarball) since filegroup files have a path likeprotobuf/external/upb/python/dist/setup.pyrather thanprotobuf/setup.pyThis was broken by 79af13a