Reuse pattern already in use for __has_attribute for __has_feature. #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
approved these changes
Aug 4, 2023
fowles
reviewed
Aug 4, 2023
| @@ -63,6 +63,7 @@ | |||
| #undef UPB_UNPOISON_MEMORY_REGION | |||
| #undef UPB_ASAN | |||
| #undef UPB_ASAN_GUARD_SIZE | |||
| #undef UPB_HAS_FEATURE | |||
There was a problem hiding this comment.
is UPB_HAS_ATTRIBUTE missing from this list?
There was a problem hiding this comment.
Yes, though it is undef'd here.
There was a problem hiding this comment.
let's be consistent and undef these in the same place (your call which)
|
I'm going to close this as we discussed offline, since we have moved upb development into the protobuf repo and this PR is not quite ready to merge as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.