Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf deps for 24.3 + cherry pick malloc_trim #1523

Closed
wants to merge 2 commits into from
Closed

Update protobuf deps for 24.3 + cherry pick malloc_trim #1523

wants to merge 2 commits into from

Conversation

honglooker
Copy link
Contributor

@honglooker honglooker commented Sep 6, 2023

haberman and others added 2 commits September 6, 2023 16:59
…en memory is freed

This partially fixes protocolbuffers/protobuf#10088.  The test case from that bug significantly improves with this change.  However we still have a global map that does not shrink, which can still create the appearance of leaking memory, as it will not be freed until the module is unloaded.

PiperOrigin-RevId: 563124724
@honglooker honglooker changed the base branch from main to 24.x September 6, 2023 17:35
@honglooker honglooker changed the base branch from 24.x to main September 6, 2023 17:35
@honglooker honglooker changed the base branch from main to 24.x September 6, 2023 17:41
@honglooker honglooker marked this pull request as draft September 6, 2023 17:42
@honglooker honglooker changed the base branch from 24.x to main September 6, 2023 17:47
@honglooker honglooker removed the request for review from mkruskal-google September 6, 2023 17:48
@honglooker honglooker closed this by deleting the head repository Sep 6, 2023
honglooker added a commit that referenced this pull request Sep 6, 2023
Update protobuf deps for 24.3 + cherry pick malloc_trim #1523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants