Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-zero minutes in the timestamp offset for JSON. #367

Merged
merged 1 commit into from Feb 3, 2021

Conversation

haberman
Copy link
Member

@haberman haberman commented Feb 2, 2021

This is to address protocolbuffers/protobuf#8071

@haberman
Copy link
Member Author

haberman commented Feb 2, 2021

I'm not sure where this compile failure came from, but it has nothing to do with this PR:

ERROR: /Volumes/BuildData/tmpfs/tmp/bazel/external/com_google_absl/absl/base/BUILD.bazel:192:11: Compiling absl/base/internal/thread_identity.cc failed: (Exit 1): wrapped_clang failed: error executing command external/local_config_cc/wrapped_clang '-D_FORTIFY_SOURCE=1' -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-assign -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG ... (remaining 41 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox wrapped_clang failed: error executing command external/local_config_cc/wrapped_clang '-D_FORTIFY_SOURCE=1' -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-assign -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG ... (remaining 41 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
clang: error: unknown argument: '-fdebug-compilation-dir'
clang: warning: .: 'linker' input unused [-Wunused-command-line-argument]

@haberman haberman merged commit b080659 into protocolbuffers:master Feb 3, 2021
haberman added a commit to haberman/protobuf that referenced this pull request Feb 3, 2021
haberman added a commit to protocolbuffers/protobuf that referenced this pull request Feb 4, 2021
* Updated upb to allow nonzero offset minutes in JSON timestamps.

This is to pick up protocolbuffers/upb#367

* Reverted error message change.

* Fixed quote chars.
@haberman haberman deleted the timestamp-minute-offset branch April 3, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants