Throw an exception with detailed information if generated code is out of date. #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_449232389
branch
from
3f0bf13
to
0238073
Compare
fowles
reviewed
May 17, 2022
python/message.c
Outdated
| "date and must be regenerated with protoc >= 3.19.0.\n" | ||
| "If you cannot immediately regenerate your protos, some other possible " | ||
| "workarounds are:\n" | ||
| " 1. Downgrade the protobuf package to 3.20.1 or lower.\n" |
python/map.c
Outdated
| @@ -159,6 +159,7 @@ bool PyUpb_MapContainer_Set(PyUpb_MapContainer* self, upb_Map* map, | |||
| case kUpb_MapInsertStatus_OutOfMemory: | |||
| return false; | |||
| } | |||
| return false; | |||
copybara-service
bot
force-pushed
the
test_449232389
branch
from
0238073
to
8ff1806
Compare
… of date. PiperOrigin-RevId: 449249979
copybara-service
bot
force-pushed
the
test_449232389
branch
from
8ff1806
to
4e2bbc8
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2022
The previous change did not have the desired effect, because the generated code uses the class named "Message" instead of "CMessage." There was no real need to use the class "CMessage" instead of "Message." The new name is simpler and will make the previous change work. PiperOrigin-RevId: 449271548
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2022
The previous change did not have the desired effect, because the generated code uses the class named "Message" instead of "CMessage." There was no real need to use the class "CMessage" instead of "Message." The new name is simpler and will make the previous change work. PiperOrigin-RevId: 449271548
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2022
The previous change did not have the desired effect, because the generated code uses the class named "Message" instead of "CMessage." There was no real need to use the class "CMessage" instead of "Message." The new name is simpler and will make the previous change work. PiperOrigin-RevId: 449309343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an exception with detailed information if generated code is out of date.