Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make load-contract infer the contract name from the ABI file #20

Closed
fvictorio opened this issue Sep 7, 2018 · 0 comments
Closed

Make load-contract infer the contract name from the ABI file #20

fvictorio opened this issue Sep 7, 2018 · 0 comments
Assignees
@lmcorbalan

Comments

@fvictorio
Copy link
Contributor

Right now the loaded contract is exposed as Contract. We should use the filename of the ABI file to infer the name.

This can be done with path.basename(abiPath, path.extname(abiPath)). Note that if the file is called Token.abi.json, then the variable will be named Token.abi and will not be available in the repl. The alternative is to do basename.split('.')[0],
@fvictorio fvictorio mentioned this issue Sep 7, 2018
Closed
@lmcorbalan lmcorbalan self-assigned this Sep 11, 2018
fernandomg added a commit that referenced this issue Sep 12, 2018
@fernandomg
Merge pull request #26 from lmcorbalan/issue-20
cfd8bad 
Issue #20 - Make load-contract infer the contract name from the ABI file
@ghost ghost removed the in progress label Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmcorbalan lmcorbalan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fvictorio @fernandomg @lmcorbalan