Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate spinners #1339

Closed
kadenzipfel opened this issue Nov 11, 2020 · 1 comment · Fixed by #1395
Closed

Consolidate spinners #1339

kadenzipfel opened this issue Nov 11, 2020 · 1 comment · Fixed by #1395
Assignees
@Mi-Lan
Labels
verification
Projects
Omen
Milestone
Version 1.2.0

Comments

@kadenzipfel
Copy link
Contributor

kadenzipfel commented Nov 11, 2020 •
edited
Loading

Currently, on the verification branch we have two spinners, spinnerMain and spinnerMainBig. Instead, we should consolidate these into one and add a size prop so we can set the size based on where it's used.

Note: This should be built on top of, and merged into, the verification branch. Same with all other issues labeled verification.
@pimato pimato added this to To do in Omen via automation Nov 12, 2020
@pimato pimato added this to the Version 1.2.0 milestone Nov 12, 2020
@pimato
Copy link
Contributor

pimato commented Nov 23, 2020

This should work:
Loading.svg.zip

Mi-Lan pushed a commit that referenced this issue Nov 23, 2020
Merge branch 'verification' of https://github.com/protofire/omen-exch…
26379b9 
…ange into fix/#1339-consolidate-spinners
@Mi-Lan Mi-Lan linked a pull request Nov 23, 2020 that will close this issue
Fix/#1339 consolidate spinners #1395
Merged
pimato pushed a commit that referenced this issue Nov 24, 2020
@Mi-Lan
Fix/#1339 consolidate spinners (#1395)
879d46e 
* consolidated spinners and changed structure a bit

* deleted unsused svg-s and updated title

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>
@pimato pimato closed this as completed Nov 24, 2020
Omen automation moved this from To do to Done Nov 24, 2020
Mi-Lan added a commit that referenced this issue Nov 27, 2020
@pimato @eccentricexit
@kadenzipfel @Mi-Lan @hexyls
Add Kleros verification process via verify tab (#1398)
8d38153 
* wip: implement basic market card

* add description

* fix: radio button behavior

* fix: missing fields in query

* fix: vulnerable links without noopener noreferrer

* feat: display submission information

* move component to new design

* display verification tab

* handle every verification state

* remove placeholders

* fix styling and add icons

* refactor: extract kleros curation logic to hook

* add kleros verification links to curate

* feat: update market details

* fix: update rinkeby contract and styling

* fix: badge link and curate actions

* revert misdeleted yarn.lock

* fix: add missing dependency

* fix: linting and prettier

* style: sort props alphabetically

* fix: yarn file

* fix: prop sorting rule inconsistency

* fix: implement review suggestions

* fix: conflicts with upstream

* fix: duplicated declarations and fix conflicts

* fix: use original verified badge

* fix: time remaining when waiting execution

* fix: use local listing criteria file

* fix: use new loading flow design

* fix: styling and option selection behavior

* fix: styling issues and missing icon

* feat: update UI on item status change

* fix: radio button styling

* fix: styling and behavior

* fix: styling and missing event listener

* feat: submit for validation from omen UI

* fix: change on kleros icon breaking UI

* refactor: styling and remove useless variables

* fix: missing dependency

* refactor: remove unused variable

* fix: incorrect dependency config

* fix: add id to kleros icon

* Replace MarketBottomNavButton component

* back button now goes to main page (#1348)

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* Fix/#1341 (#1355)

* started solving

* consolidated iconTick and refactored code to fit needs

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* style changes to the challenge section (#1359)

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* added hyperlink for the verified on the kleros curation (#1370)

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* changed size of icon and border only shown when not active (#1367)

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* added verified remove section (#1364)

* added verified remove section

* mistype fixed

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* changed margin of description to 20px (#1368)

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* verify shown only for open markets (#1350)

* verify shown only for open markets

* prettier additions

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* changed location of exported styled components (#1357)

* changed location of exported styled components

* changed location of exports

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* updated button so that they have outline styling instaed of secondary (#1381)

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* changed so that ETH is bolded for not verified market (#1379)

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* changed styles of verification process icons (#1374)

* changed styles of verification process icons

* updated logo for pending markets

* updated so that whitespace is not clickable

* added back the html links instead of programtic ones

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* updated radioButtonWrapper (#1382)

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* Feature/#1371 (#1386)

* intial commit

* work in progress

* updated kleros curation so that it has modal and also added reqeust verification to cpk

* added types

* updated verificationCheker and changes from code review

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* changed color of challengeable market eth (#1394)

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* Fix/#1339 consolidate spinners (#1395)

* consolidated spinners and changed structure a bit

* deleted unsused svg-s and updated title

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* update time remaining (#1397)

* button styling seems to be overwritten (#1399)

* button styling seems to be overwritten

* fixed button for remove market

Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>

* deleted unused button updated constants file and deleted env example

Co-authored-by: mtsalenc <mtsalenc@gmail.com>
Co-authored-by: Kaden Zipfel <kaden.zipfel@hotmail.com>
Co-authored-by: Milan Rasovic <33226956+Mi-Lan@users.noreply.github.com>
Co-authored-by: Milan Rasovic <ezo@Milans-MacBook-Pro.local>
Co-authored-by: hexyls <hexyls@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mi-Lan Mi-Lan

Labels
verification
Projects
Omen
  
Done
Milestone
Version 1.2.0
Development

Successfully merging a pull request may close this issue.

Fix/#1339 consolidate spinners protofire/omen-exchange
3 participants
@pimato @kadenzipfel @Mi-Lan