Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kleros market verification UI #1176

Closed
wants to merge 45 commits into from
Closed

Conversation

eccentricexit
Copy link
Contributor

@eccentricexit eccentricexit commented Oct 12, 2020

This PR addresses #1118.
In addition:

  • Fixes links vulnerable to "tabnabbing" due to missing noopener noreferer tags on links with target=_blank. See this for more.
  • Fixes wrong filter option No Sources. It was returning everything and ignoring curation, when it instead should return all not verified markets.

@eccentricexit eccentricexit changed the title WIP: add market verification UI Add kleros market verification UI Oct 16, 2020
Copy link
Contributor

@kadenzipfel kadenzipfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work @mtsalenc! Just a few small changes

@pimato pimato added this to In progress in Omen via automation Oct 20, 2020
@pimato pimato added this to the Version 1.1.9 milestone Oct 20, 2020
@pimato pimato moved this from In progress to Review in progress in Omen Oct 26, 2020
@pimato pimato modified the milestones: Version 1.1.9, Version 1.2.0 Oct 28, 2020
@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

@mtsalenc could the hyperlink point to the local file of the market validity rules which we already have in the footer?
Bildschirmfoto 2020-10-28 um 15 04 38

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

@mtsalenc Now that we now we need to have a loading sequence, could we implement a loading screen like this:
Bildschirmfoto 2020-10-28 um 17 08 20

Figma:
Design Specification

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

  • It looks like the whole row is clickable, but instead only the circle button should be clickable.
  • Also you can enable the circle icon but not disable again which should be possible!

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

Please check the designs for the disabled,active and idle circle button here
Bildschirmfoto 2020-10-28 um 20 13 37

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

Bildschirmfoto 2020-10-28 um 20 14 37

there should be only a margin-top: 20px here instead of having margin: 20px 0;

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

The message box needs correct designs. currently:
Bildschirmfoto 2020-10-28 um 20 16 15

should:
Bildschirmfoto 2020-10-28 um 20 16 59

You can access the design specification here

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

the circle onHover style do not match according to my designs here

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

on default and if the market was not verified by anyone the verify page should look like this:
Bildschirmfoto 2020-10-28 um 20 22 50

currently the default view looks like this:
Bildschirmfoto 2020-10-28 um 20 23 17

the message box should only be visible once the user triggered the circle icon active

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

@mtsalenc is there a way to test out the whole verification process on Rinkeby?

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

@mtsalenc just saw that Omen needs to be refreshed after the request verification transaction was confirmed. Could we make sure that Omen detects that the verification process has started?

looks like this is also happening for the verification process, waiting to see the verification here:
Bildschirmfoto 2020-10-28 um 20 42 02

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

Bildschirmfoto 2020-10-28 um 20 35 38

should look like:
Bildschirmfoto 2020-10-28 um 20 42 57

  • Ends in ... text should align to the right and should have the color #37474F
  • Please add the schedule icon

@pimato
Copy link
Contributor

pimato commented Oct 28, 2020

-verification icon is not aligned vertical with verified

  • verified is not font-size medium:

Bildschirmfoto 2020-10-28 um 20 45 12

@pimato
Copy link
Contributor

pimato commented Nov 3, 2020

looks great already!
just a few more comments:

We should have a Back - Button instead of a Cancel - Button which will bring the user back to the markets overview page.

Currently:
Bildschirmfoto 2020-11-03 um 12 25 59

Should:
Bildschirmfoto 2020-11-03 um 12 26 05

@pimato
Copy link
Contributor

pimato commented Nov 3, 2020

The active button should not have a border:
currently:
Bildschirmfoto 2020-11-03 um 12 26 40

should:
Bildschirmfoto 2020-11-03 um 12 27 13

@pimato
Copy link
Contributor

pimato commented Nov 3, 2020

  • The DXdao circle button be disabled for now until we implemented the connection.
    currently:

Bildschirmfoto 2020-11-03 um 12 31 34

should:
Bildschirmfoto 2020-11-03 um 12 28 18

@pimato
Copy link
Contributor

pimato commented Nov 3, 2020

The designs for the list item has slightly changed, coud you please do the small changes:

  • curation team circle on the left has now a 48x48 instead of just 38x38 dimension
  • circle button increased to 40x40 from 38x38.

Figma:
Design specification

Copy link
Contributor

@pimato pimato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@eccentricexit eccentricexit marked this pull request as ready for review November 14, 2020 20:55
@kadenzipfel
Copy link
Contributor

Closing this as it's been merged into the verification branch

Omen automation moved this from Review in progress to Done Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Omen
  
Done
Development

Successfully merging this pull request may close these issues.

Kleros curate verification process
4 participants