Merge FpmmLiquidity and FpmmTrade

[altbee]

I think we can merge all fields and add one more field to check if it's FpmmLiquidity or FpmmTrade.

[davidalbela]

They come from different FPMM contract events.

[altbee]

@davidalbela

protofire/omen-exchange#1194
Mi-Lan needs to sort fpmmLiquidities and fpmmTrades items by creationTimestamp and implement pagination.
Using the following query,

For example, using the following query, he gets the first 3 liquidities and trades.
But he needs to only 3 items( merge 3 liquidities and trades and totally 6 items, sort by date and get the first 3)

Is there any solution to implement his needs using query, do you think?
It's not a good idea to fetch all liquidities/trades, merge them, sort them and implement pagination.

{
  fpmmLiquidities(
    where: {
      fpmm: "0x748a098efb58b8f61961cab15bcc92a3174c221a"
    }
    first:3
    orderBy: creationTimestamp
  ) {
    outcomeTokenAmounts
    type
  }
  fpmmTrades(
    where:{
      fpmm:"0x748a098efb58b8f61961cab15bcc92a3174c221a"
    }
    first:3
    orderBy: creationTimestamp
  ){
    type
    feeAmount
    outcomeTokensTraded
    collateralToken
  }
}

[davidalbela]

The entities are being used by the bots for different approaches.

What about create a common entity? Eg: FPMMTransaction with the following attributes:

id: ID!
fpmm: FixedProductMarketMaker!
user: Account!
transactionType: TransactionType!
collateralAmount: BigInt! 
collateralTokenAddress: Bytes!
collateralTokenAmount: BigInt!
creationTimestamp: BigInt!

Where collateralAmount field is the sharesMinted/sharesBurnt from a FPMMFundingAdded/FPMMFundingRemoved event and investmentAmount/returnAmount from a FPMMBuy /FPMMSell event.

There is also a FpmmParticipation entity being used for buy, sell, and transfer events.

[davidalbela]

Could be possible to include the tx hash on it?

[Mi-Lan]

@davidalbela it seems that astro514 made those changes #80 for tx hash and also for main issue gejeduck@a66cab1

[pimato]

this issue was fixed by #81