Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

func-order confused by modifiers and constructors. #13

Closed
davesag opened this issue Nov 27, 2017 · 1 comment
Closed

func-order confused by modifiers and constructors. #13

davesag opened this issue Nov 27, 2017 · 1 comment
Milestone

Comments

@davesag
Copy link

davesag commented Nov 27, 2017

Running solhint over this contract

pragma solidity ^0.4.18;


contract TestThing {

    modifier validSender() {
        require(msg.sender != 0x0);
        _;
    }

    function statusIsOkay() external view returns(bool) {
        return true;
    }

    function TestThing() public validSender() {
        // does something
    }
}

gives error

11:5  error    Function order is incorrect, external constant function can not go after  function  func-order
@idrabenia idrabenia added this to the v1.1.9 milestone Nov 28, 2017
@idrabenia
Copy link
Contributor

Hi @davesag ,

Thank you for this feedback!

We are fixed this issue and it will be available in next release (at the end of this week).

- Ilya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants