Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: no-unsed-functions #257

Open
gitpusha opened this issue Oct 18, 2020 · 1 comment
Open

Feature request: no-unsed-functions #257

gitpusha opened this issue Oct 18, 2020 · 1 comment
Labels
awaiting user feedback awaiting user feedback feature-request new-rule

Comments

@gitpusha
Copy link

Requesting new rule to be added to solhint that's similar to no-unused-vars but for no-unsed-functions and it would look at all functions that are not virtual and thus should really be used.
@dbale-altoros
Copy link
Collaborator

@gitpusha
As I see it, we should only apply this rule to private functions on the same contract since solhint only works at file level
If a function is in contract A and another contract (B) is calling A's function, when solhint evaluates A it will show that the function is not being called...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting user feedback awaiting user feedback feature-request new-rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fvictorio @gitpusha @dbale-altoros