Don't import test code from main code

[fvictorio]

Some file is importing something from some test file. This means that we have to include the test directory in the published package, but besides that it's just a bad idea. I haven't looked into it, but it's probably easy to fix.

[pfmescher]

I haven't found any references to test files outside these

pablo@pop-os:~/protofire/solhint/lib$ grep 'require(.*test' . -r --include='*.js'
./rules/best-practises/reason-string.js:          code: require('../../../test/fixtures/best-practises/require-with-reason'),
./rules/best-practises/reason-string.js:          code: require('../../../test/fixtures/best-practises/require-without-reason'),
./rules/best-practises/max-states-count.js:          code: require('../../../test/fixtures/best-practises/number-of-states-low'),
./rules/best-practises/max-states-count.js:          code: require('../../../test/fixtures/best-practises/number-of-states-high'),
./rules/best-practises/payable-fallback.js:          code: require('../../../test/fixtures/best-practises/fallback-payable'),
./rules/best-practises/payable-fallback.js:          code: require('../../../test/fixtures/best-practises/fallback-not-payable'),
./rules/best-practises/code-complexity.js:          code: require('../../../test/fixtures/best-practises/code-complexity-low'),
./rules/best-practises/code-complexity.js:          code: require('../../../test/fixtures/best-practises/code-complexity-high'),
./rules/order/func-order.js:          code: require('../../../test/fixtures/order/func-order-constructor-first'),
./rules/order/func-order.js:          code: require('../../../test/fixtures/order/func-order-constructor-not-first'),
./rules/order/ordering.js:      good: require('../../../test/fixtures/order/ordering-correct'),
./rules/order/ordering.js:      bad: require('../../../test/fixtures/order/ordering-incorrect'),
./rules/order/visibility-modifier-order.js:          code: require('../../../test/fixtures/order/visibility-modifier-first'),
./rules/order/visibility-modifier-order.js:          code: require('../../../test/fixtures/order/visibility-modifier-not-first'),
./rules/security/reentrancy.js:          code: require('../../../test/fixtures/security/reentrancy-invulenarble')[0],
./rules/security/reentrancy.js:          code: require('../../../test/fixtures/security/reentrancy-invulenarble')[1],
./rules/security/reentrancy.js:          code: require('../../../test/fixtures/security/reentrancy-invulenarble')[2],
./rules/security/reentrancy.js:          code: require('../../../test/fixtures/security/reentrancy-vulenarble')[0],
./rules/security/reentrancy.js:          code: require('../../../test/fixtures/security/reentrancy-vulenarble')[1],
./rules/security/mark-callable-contracts.js:          code: require('../../../test/fixtures/security/external-contract-trusted'),
./rules/security/mark-callable-contracts.js:          code: require('../../../test/fixtures/security/external-contract-untrusted'),
./rules/security/func-visibility.js:          code: require('../../../test/fixtures/security/functions-with-visibility').join('\n'),
./rules/security/func-visibility.js:          code: require('../../../test/fixtures/security/functions-without-visibility').join('\n'),
./rules/security/check-send-result.js:          code: require('../../../test/fixtures/security/send-result-checked'),
./rules/security/check-send-result.js:          code: require('../../../test/fixtures/security/send-result-ignored'),
./rules/security/avoid-low-level-calls.js:const LOW_LEVEL_CALLS = require('../../../test/fixtures/security/low-level-calls')
./rules/miscellaneous/quotes.js:          code: require('../../../test/fixtures/miscellaneous/string-with-double-quotes'),
./rules/miscellaneous/quotes.js:          code: require('../../../test/fixtures/miscellaneous/string-with-single-quotes'),
./rules/miscellaneous/comprehensive-interface.js:          code: require('../../../test/fixtures/miscellaneous/public-function-with-override'),
./rules/miscellaneous/comprehensive-interface.js:          code: require('../../../test/fixtures/miscellaneous/public-function-no-override'),

which all seem to be related to documentation. I also noticed we are currently publishing the test folder in it's entirety since it is included in the files directive in the package.json file

  "files": [
    "/conf/",
    "/lib/",
    "/test/",
    "/solhint.js"
  ],

in any case, all the above examples are used as documentation and do not actually require anything else from any test files.. so I can propose two possible solutions to avoid shipping the test folder: move the fixtures to their own folder or explicitly include only the fixtures instead of the whole test folder (might require some workaround around the required paths for this to work)
in either case.. I don't really think this is a big deal at all and we can potentially just leave this as-is. What do you think? @fvictorio

[fvictorio]

I'd say that we close this issue and open a new one about not publishing the test directory. I'm going to do that.