Fix data location "calldata" in external function parameters throws an "Unused variable" error #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvictorio
reviewed
Aug 9, 2019
| rules: { 'no-unused-vars': 'error' } | ||
| }) | ||
|
|
||
| assert.equal(report.errorCount, 0) |
There was a problem hiding this comment.
Why there are no errors here? bar is not used inside this function. Is there something special about calldata that makes it being excluded from the no-unused-vars rule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
The error occurs when using Truffle 5 and Solidity 0.5.0.
The PR removes an unused function called
getLocFromIndexso the coverage will be increased.If the
no-unused-varsrule adds a variable to validate it, we check if the variable have the expressioncalldata. Also added some tests.Regards