Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate mark-callable-contract #218

Merged
merged 1 commit into from May 7, 2020
Merged

Deprecate mark-callable-contract #218

merged 1 commit into from May 7, 2020

Conversation

fvictorio
Copy link
Contributor

Closes #216. Open for discussion.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 92.522% when pulling e18fd3d on deprecate-mark-callable-contract into 4b2a229 on master.

patitonar
patitonar approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my experience, I always ended up disabling this rule. This also seems to be the case for other projects https://github.com/search?p=2&q=mark-callable-contracts&type=Code

@fvictorio fvictorio merged commit 0480c63 into master May 7, 2020
@pablofullana pablofullana deleted the deprecate-mark-callable-contract branch October 16, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patitonar patitonar patitonar approved these changes

@pablofullana pablofullana Awaiting requested review from pablofullana

@fernandomg fernandomg Awaiting requested review from fernandomg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider deprecating mark-callable-contract
3 participants
@fvictorio @coveralls @patitonar