fix: transfers with .call excluded from warning as low level code #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2023
|
@dbale-altoros thanks for the credit. |
pfmescher
approved these changes
Feb 3, 2023
fvictorio
reviewed
Feb 5, 2023
Comment on lines
36
to
37
| anyAddress.call{value: 1 ether}(""); | ||
| anyAddress.call.value(code)(); |
There was a problem hiding this comment.
a.call.value is deprecated.
Suggested change
| anyAddress.call{value: 1 ether}(""); | |
| anyAddress.call.value(code)(); | |
| anyAddress.call{value: 1 ether}(""); |
There was a problem hiding this comment.
Notice that this means updating the implementation and the tests.
dbale-altoros
force-pushed
the
fix/avoid-low-level-calls
branch
from
64b51ec
to
bc437e3
Compare
fvictorio
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from
#329
All credits to @potomak