Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 one-contract-per-file: ignore interfaces #514

Merged
merged 3 commits into from
Oct 27, 2023
Merged

🐛 one-contract-per-file: ignore interfaces #514

merged 3 commits into from
Oct 27, 2023

Conversation

cruzdanilo
Copy link
Contributor

@cruzdanilo cruzdanilo commented Oct 23, 2023 •
edited
Loading

according to the style guide:

If a contract file includes multiple contracts and/or libraries, then the filename should match the core contract. This is not recommended however if it can be avoided.

@dbale-altoros
Copy link
Collaborator

@cruzdanilo thanks for your addition
Would you mind adding some test into this, so the PR is complete and i can merge it ? ...

Thanks a lot!!!!!

@dbale-altoros dbale-altoros self-requested a review October 26, 2023 13:11
@dbale-altoros dbale-altoros added the awaiting user feedback awaiting user feedback label Oct 26, 2023
@cruzdanilo
Copy link
Contributor Author

🫡

@dbale-altoros
Copy link
Collaborator

@cruzdanilo great work man!
Thanks a lot
I will approve this and put it in the next Solhint version pretty soon (I'll try to include your name in the changelog)
Stay tuned

Thanks a lot for this!
Join our Solhint Discord if you like:
https://discord.gg/4TYGq3zpjs

@dbale-altoros dbale-altoros merged commit f9804a8 into protofire:develop Oct 27, 2023
10 checks passed
@juanpcapurro juanpcapurro mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbale-altoros dbale-altoros dbale-altoros approved these changes

Assignees
No one assigned
Labels
awaiting user feedback awaiting user feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cruzdanilo @dbale-altoros