function-order now also applies to public view/pure, not just external.

[nventuro]

Added for consistency's sake. If accepted, we may also want to include internal and private here. Distinction between view and pure is also missing, is that something we want to tackle?

[coveralls]

Coverage increased (+0.002%) to 99.528% when pulling 7ef5fb9 on nventuro:function-order-public-constant into f389547 on protofire:master.

[fvictorio]

Thanks @nventuro, and sorry for taking so long to check this.

Distinction between view and pure is also missing, is that something we want to tackle?

I'm not against this, but it might be a constraint too harsh. Maybe it could be an extra option for the rule?

In any case, what should be the order? I guess pure functions should be after view functions, since they are more "const".

[nventuro]

constant was removed in Solidity 0.5.0, so I don't think that'd be 'too harsh'.

The ordering you suggested makes sense, and is in line with the Solidity style guide.

[fvictorio]

constant was removed in Solidity 0.5.0, so I don't think that'd be 'too harsh'.

I meant forcing certain order for view and pure functions; not allowing to alternate view and pure functions, for example.

[nventuro]

Ah, in that case I'd consider making it optional, yes. I don't feel too strongly about function order though, so I may not be the best person to ask about this 😛

[fvictorio]

@nventuro Sorry for not merging this before. I'll make a release now so that it's available.