Added unit tests

protoman92 · Apr 28, 2017 · 9f2b44a · 9f2b44a
1 parent 83ccd44
commit 9f2b44a
Show file tree

Hide file tree

Showing 4 changed files with 223 additions and 206 deletions.
diff --git a/SwiftDialogController/view/PaddingDialogViewType.swift b/SwiftDialogController/view/PaddingDialogViewType.swift
@@ -201,14 +201,14 @@ public extension PaddingDialogViewType where Self: UIView {
 
         let allConstraints = superview.constraints
         let paddingConstraints = self.paddingConstraints(for: superview)
+        let identifiers = paddingConstraints.flatMap({$0.identifier})
 
-        for constraint in paddingConstraints {
-            if let oldConstraint = allConstraints.filter({
-                $0.identifier == constraint.identifier
-            }).first {
-                superview.replaceConstraint(oldConstraint, with: constraint)
-            }
-        }
+        let oldConstraints = identifiers.flatMap({identifier in
+            allConstraints.filter({$0.identifier == identifier}).first
+        })
+
+        superview.removeConstraints(oldConstraints)
+        superview.addConstraints(paddingConstraints)
     }
 }
 

diff --git a/SwiftDialogController/view/RatioDialogViewType.swift b/SwiftDialogController/view/RatioDialogViewType.swift
@@ -177,17 +177,14 @@ public extension RatioDialogViewType where Self: UIView {
 
         let allConstraints = superview.constraints
         let ratioConstraints = self.ratioConstraints(for: superview)
+        let identifiers = ratioConstraints.flatMap({$0.identifier})
 
-        for constraint in ratioConstraints {
-            if
-                let identifier = constraint.identifier,
-                let oldConstraint = allConstraints.filter({
-                    $0.identifier == identifier
-                }).first
-            {
-                superview.replaceConstraint(oldConstraint, with: constraint)
-            }
-        }
+        let oldConstraints = identifiers.flatMap({identifier in
+            allConstraints.filter({$0.identifier == identifier}).first
+        })
+
+        superview.removeConstraints(oldConstraints)
+        superview.addConstraints(ratioConstraints)
     }
 }
 

diff --git a/SwiftDialogController/view/RatioPaddingDialogViewType.swift b/SwiftDialogController/view/RatioPaddingDialogViewType.swift
@@ -62,17 +62,14 @@ public extension RatioPaddingDialogViewType where Self: UIView {
 
         let allConstraints = superview.constraints
         let rpConstraints = self.ratioPaddingConstraints(for: superview)
+        let identifiers = rpConstraints.flatMap({$0.identifier})
 
-        for constraint in rpConstraints {
-            if
-                let identifier = constraint.identifier,
-                let oldConstraint = allConstraints.filter({
-                    $0.identifier == identifier
-                }).first
-            {
-                superview.replaceConstraint(oldConstraint, with: constraint)
-            }
-        }
+        let oldConstraints = identifiers.flatMap({identifier in
+            allConstraints.filter({$0.identifier == identifier}).first
+        })
+
+        superview.removeConstraints(oldConstraints)
+        superview.addConstraints(rpConstraints)
     }
 }