Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road shields for Hawaii show with US interstate artwork #86

Closed
nvkelso opened this issue Aug 14, 2023 · 0 comments · Fixed by #92
Closed

Road shields for Hawaii show with US interstate artwork #86

nvkelso opened this issue Aug 14, 2023 · 0 comments · Fixed by #92

Comments

@nvkelso
Copy link
Collaborator

nvkelso commented Aug 14, 2023

Instead of testing the network value for contains("I "), it should be startsWith("I "), else it catches networks like HI XXXX in error. My bad as a newbie to Java but easy to fix.

For example:

image

https://github.com/protomaps/basemaps/blob/main/tiles/src/main/java/com/protomaps/basemap/layers/Roads.java#L40-L45

if (shieldText.contains("US ")) {
          shieldText = shieldText.replaceAll("US ", "");
          networkVal = "US:US";
        } else if (shieldText.contains("I ")) {
          shieldText = shieldText.replaceAll("I ", "");
          networkVal = "US:I";
        } else {
          // This should be replaced by walking the way's relations (which reliably set network)
          networkVal = "other";
        }
@bdon bdon closed this as completed in #92 Aug 16, 2023
bdon added a commit that referenced this issue Sep 15, 2023
…114)

* introduce Locales; always use US one for highway shields [#86, #92]

* bump junit; parameterize tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant