-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-pmtiles docker image on GitHub registry #11
go-pmtiles docker image on GitHub registry #11
Conversation
.github/workflows/publish.yml
Outdated
username: ${{ github.actor }} | ||
password: ${{ secrets.GITHUB_TOKEN }} | ||
registry: ghcr.io | ||
repository: protomaps/go-pmtiles/go-pmtiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be protomaps/go-pmtiles/go-pmtiles
or can it be just protomaps/go-pmtiles
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good hint. I had thought that subnaming was required. I tested it and it works great without. Even documentation does not saying sth. about it any longer. Maybe that requirement was changed recently with migration to ghct.io, or I was on the wrong path all the time. Anyway, I changed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! will try it out.
@fraank can you verify that the image pushed to ghcr is working? Also the build output has these two warnings:
|
yeah, the Dockerfile is somehow "strange". I made the same mistake. This docker-compose config works for me:
|
@bdon Something is not working in my examples as expected and I cannot (yet) figure out if it depends on the image or usage. I downloaded a quite big map as Any idea what i missed? |
@fraank I haven't had a chance to run this in detail yet, but can you confirm your container has access to the S3 bucket via either IAM roles or public bucket settings? |
@bdon Yep, i can confirm that it is public available for my test. I tried it with a local directory as well. |
@fraank can you try this change? #12 This switches to Alpine linux which should be more minimal and copies over the SSL cert toolchain from the image, which should make HTTPS fetches work. Details about alpine vs other image here: https://hub.docker.com/_/golang |
@bdon yes, serving from S3 and local is now working. I created a small Pull Request for making docker (compose) things a little bit more elegant. |
could fix #3
(sorry, first pull request was based on wrong branch)
some points to extend: