Ensure write failures are handled during conversion #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28.
There are several places where
File.write()
was called but the return value was ignored, meaning any failures would be silent.Tested this locally by creating an artificially small filesystem and placing either the temp directory (via
--tempdir
) or output file in it to simulate disk full scenarios.(below is for Mac OS, but there are equivalent options for Linux)
And some test cases, both of which complete successfully without this PR:
Also just a note, there are definitely other places where the error return value should probably be checked to avoid silent data corruption (for example), but I haven't done an exhaustive review.