Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to line labeling #1

Closed
3 tasks done
bdon opened this issue Apr 10, 2021 · 1 comment
Closed
3 tasks done

Improvements to line labeling #1

bdon opened this issue Apr 10, 2021 · 1 comment
Assignees
@bdon
Labels
enhancement New feature or request i18n Internationalization
Milestone
Parity

Comments

@bdon
Copy link
Member

bdon commented Apr 10, 2021 •
edited

  • Position a label at the best position on the line
  • Multiple bounding boxes for a single label
  • line can be labeled multiple times
@bdon bdon self-assigned this May 12, 2021
@bdon bdon added the enhancement New feature or request label May 12, 2021
bdon added a commit that referenced this issue Jun 8, 2021
@bdon
line labeling needs work; comment out [#1]
04aa76d
bdon added a commit that referenced this issue Jun 8, 2021
@bdon
pass font string properly in line labeler [#1]
b0cecd7
@bdon bdon mentioned this issue Jun 10, 2021
Closed
@bdon bdon added this to the 1.0 milestone Jun 25, 2021
@bdon bdon mentioned this issue Jun 30, 2021
Closed
bdon added a commit that referenced this issue Jul 3, 2021
@bdon
line labels have start and end cells [#1]
bdfd72f
bdon added a commit that referenced this issue Jul 4, 2021
@bdon
road labels on default style, prune correctly [#1,#24]
aca496e
bdon added a commit that referenced this issue Jul 4, 2021
@bdon
implement ShieldSymbolizer [#1]
6812a46
bdon added a commit that referenced this issue Jul 4, 2021
@bdon
use cells for line label bboxes [#1]
6d630d7
@bdon bdon added the i18n Internationalization label Sep 23, 2021
bdon added a commit that referenced this issue Oct 8, 2021
@bdon
generate multiple line labeling positions [#1, #24]
9447771
bdon added a commit that referenced this issue Oct 8, 2021
@bdon
generate multiple line labeling positions [#1, #24]
360c8bc
bdon added a commit that referenced this issue Oct 8, 2021
@bdon
line segment labeling: candidate segment is only as long as label [#1,#…
7eec663 
…24]
bdon added a commit that referenced this issue Oct 8, 2021
@bdon
repeat labels for a single candidate segment [#1,#24]
0db5cfd
@bdon
Copy link
Member Author

bdon commented Oct 8, 2021

Current problem areas:

Labels should be positioned on the actual geometry, not a straight line: Chuo Expressway @ #17/35.66661/139.55926
Screen Shot 2021-10-08 at 9 08 37 PM

When a label is repeated, it should not be too close to the next segment of the same feature:

Some places in Denver have way too few road labels: (straight unlabeled roads)

Screen Shot 2021-10-08 at 9 12 03 PM

bdon added a commit that referenced this issue Oct 8, 2021
@bdon
repeatDistance and maxLabelChars are evaluated attributes [#1]
fa3a377
bdon added a commit that referenced this issue Oct 13, 2021
@bdon
generate multiple line labeling positions [#1, #24]
638a2e3
bdon added a commit that referenced this issue Oct 13, 2021
@bdon
line segment labeling: candidate segment is only as long as label [#1,#…
ed4e4fa 
…24]
bdon added a commit that referenced this issue Oct 13, 2021
@bdon
repeat labels for a single candidate segment [#1,#24]
41ce144
bdon added a commit that referenced this issue Oct 13, 2021
@bdon
repeatDistance and maxLabelChars are evaluated attributes [#1]
bc92f8f
bdon added a commit that referenced this issue Oct 13, 2021
@bdon
leave cross-segment deduplication up to the cross-feature deduplicator [
64e94fa 
#1]
bdon added a commit that referenced this issue Oct 13, 2021
@bdon
generate multiple line labeling positions [#1, #24]
b135288 
line segment labeling: candidate segment is only as long as label [#1,#24]

repeat labels for a single candidate segment [#1,#24]

repeatDistance and maxLabelChars are evaluated attributes [#1]

leave cross-segment deduplication up to the cross-feature deduplicator [#1]
bdon added a commit that referenced this issue Oct 14, 2021
@bdon
adjust defaults for line labeling [#1, #24]
6429a66
bdon added a commit that referenced this issue Oct 14, 2021
@bdon
limit label repetition when overzooming to a sensible default [#1]
1b99699
bdon added a commit that referenced this issue Oct 14, 2021
@bdon
line label cell size is derived automatically from text metrics [#1,#24]
fdf8a42
@bdon bdon closed this as completed Oct 14, 2021
bdon added a commit that referenced this issue Oct 14, 2021
@bdon
tweak MIN_LABELABLE_DIM to 20px for better road label density at high…
38cc59a 
… zooms [#1]
bdon added a commit that referenced this issue Oct 14, 2021
@bdon
tweak MIN_LABELABLE_DIM to 20px for better road label density at high…
8811ad3 
… zooms [#1]

fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdon bdon

Labels
enhancement New feature or request i18n Internationalization
Projects
None yet
Milestone
Parity
Development

No branches or pull requests
1 participant
@bdon